Skip to content

TST: remove tests and docs for legacy (pre 0.12) hdf5 support #17404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Aug 31, 2017

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Removing tests for old compatability because this issue is sufficiently old now, that people should be expected to have solved this themselves by now.

The first commit removes the legacy test for pandas v0.10. The second commit removes the legacy test for pandas v0.11.

This pull request replaces #17398.

See also discussion in #17375.

@topper-123 topper-123 force-pushed the remove_tests_hdf_pandas_pre_011 branch from dbf9ddd to 2ca823b Compare August 31, 2017 20:06
@topper-123 topper-123 force-pushed the remove_tests_hdf_pandas_pre_011 branch from 2ca823b to 57e9ccb Compare August 31, 2017 21:00
@codecov
Copy link

codecov bot commented Aug 31, 2017

Codecov Report

Merging #17404 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17404      +/-   ##
==========================================
- Coverage   91.03%   91.01%   -0.03%     
==========================================
  Files         163      163              
  Lines       49580    49580              
==========================================
- Hits        45137    45126      -11     
- Misses       4443     4454      +11
Flag Coverage Δ
#multiple 88.8% <ø> (ø) ⬆️
#single 40.25% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️
pandas/io/pytables.py 92.79% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062f6f1...330b2cd. Read the comment docs.

@sinhrks sinhrks added Compat pandas objects compatability with Numpy or Python functions IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite labels Aug 31, 2017
@topper-123 topper-123 changed the title TST: remove tests and docs for legacy (pre 0.11) hdf5 support TST: remove tests and docs for legacy (pre 0.12) hdf5 support Sep 1, 2017
@jreback jreback added this to the 0.21.0 milestone Sep 1, 2017
@jreback jreback merged commit f7fe429 into pandas-dev:master Sep 1, 2017
@jreback
Copy link
Contributor

jreback commented Sep 1, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants